[pso] [tema3 windows]test

[Florin Antonescu]

1. Atat in functia de citire cat si cea de scriere se intampla urmatorul lucru:
la sfarsitul testului primesc doua IRP-uri cu offsetul 99614208. Eu m-as fi asteptat ca primul IRP sa aiba offsetul 99614208 si al doilea offsetul de 99614720 = LOG_DSK_SIZE.
2. Eu am considerat un IRP ca out of bounds daca offset.QuadPart >= LOG_DSK_SIZE ,sau nu asta este conditia corecta?
3. Cum ar trebui sa arate offsetul si lungimea IRP-ului out of bounds din test?

Florin



----- Original Message ----
From: Razvan Deaconescu <razvand at cs.pub.ro>
To: Proiectarea Sistemelor de Operare <pso at cursuri.cs.pub.ro>
Sent: Friday, May 9, 2008 6:39:03 PM
Subject: Re: [pso] [tema3 windows]test

On Fri, 2008-05-09 at 07:34 -0700, Florin Antonescu wrote:
> Am observat urmatorul comportament: in ultima parte a testului in care
> se verifica write/read out of bounds driverul meu primeste doua cereri
> de read/write ambele cu acelasi offset: 99614208 si lungimea 512.
> Banuiesc ca a doua cerere ar fi trebuit sa vina cu offsetul 99614720
> pt a fi out of bounds,  nu? Este vreo greseala in test?

Ce greseala ar putea fi in test? Cum ai ajuns la concluzia asta? :-)

Pe scurt:

--
ssr_test_out_of_bounds

SetFilePointer(fd, LOG_DSK_SIZE - SECTOR_SIZE);
WriteFile(fd, SECTOR_SIZE);    /* OK */
WriteFile(fd, SECTOR_SIZE);    /* NOT OK */
SetFilePointer(fd, LOG_DSK_SIZE - SECTOR_SIZE);
ReadFile(fd, SECTOR_SIZE);     /* OK */
ReadFile(fd, SECTOR_SIZE);     /* NOT OK */
---

Exprimarea ta este inconsistenta. Ce inseamna primeste doua cereri de
read/write? Sunt de read sau sunt de write? Incearca sa eviti cuvintele
din engleza care pot fi confundate cu apeluri de functii.

Razvan



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

_______________________________________________
pso mailing list
pso at cursuri.cs.pub.ro
http://cursuri.cs.pub.ro/cgi-bin/mailman/listinfo/pso



      ____________________________________________________________________________________
Be a better friend, newshound, and 
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://cursuri.cs.pub.ro/pipermail/pso/attachments/20080509/1ff05228/attachment.htm