[so] [Tema5] Teste vmchecker picate

Mon May 22 22:45:54 EEST 2017

Salut, Relu!

Nu cred că folosești ultima versiune a checker-ului. Se pare că nu ai
sincronizat repo-ul de pe gitlab[1] cu cel de pe github[2], pentru că pe
cel de pe github fiecare test are are configurat un timeout de 20 de
secunde[3]. În repo-ul tău nu folosești niciun timeout, din cazua asta îți
trece local.
În primul rând ar trebui să aduci schimbările din "upstream" în repo-ul
tău[4]. Apoi ar trebui să faci debugging să vezi de ce durează testul 33
atât de mult, ar trebui să dureze doar câteva secunde.

[1] https://gitlab.cs.pub.ro/relu.dragan/l3-so-assignments
[2] https://github.com/systems-cs-pub-ro/so-assignments
[3]
https://github.com/systems-cs-pub-ro/so-assignments/blob/master/5-aws/checker-lin/run_all.sh#L6
[4] https://help.github.com/articles/syncing-a-fork/

Numai bine,
Răzvan

On Mon, May 22, 2017 at 9:44 PM Relu Dragan via so <so at cursuri.cs.pub.ro>
wrote:

> Salut,
>
> Am rulat acum pe masina virtuala de linux si am un timp de 1m 41 sec.
> Asa arata outputul de pe vm checker. Observ ca imi trece testul 35 desi
> imi pica testul 34 iar testul 33 nu este afisat.
>
> ./src/server.c:363: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
> ./src/server.c:213: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
> ./src/server.c:94: WARNING:LINE_SPACING: Missing a blank line after declarations
> ./src/vector.c:98: WARNING:LONG_LINE: line over 80 characters
> ./src/server.c:514: ERROR:SPACING: space required before the open parenthesis '('
> ./src/server.c:498: ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
> ./src/server.c:76: ERROR:TRAILING_WHITESPACE: trailing whitespace
> 00) Sources check...........................................failed  [00/95]
> 01) Test executable exists..................................passed  [01/90]
> 02) Test executable runs....................................passed  [01/90]
> 03) Test listening..........................................passed  [01/90]
> 04) Test listening on port..................................passed  [01/90]
> 05) Test accepts connections................................passed  [01/90]
> 06) Test accepts multiple connections.......................passed  [01/90]
> 07) Test epoll usage........................................passed  [01/90]
> 08) Test disconnect.........................................passed  [01/90]
> 09) Test multiple disconnect................................passed  [01/90]
> 10) Test connect disconnect connect.........................passed  [01/90]
> 11) Test multiple connect disconnect connect................passed  [01/90]
> 12) Test unordered connect disconnect connect...............passed  [01/90]
> 13) Test replies http request...............................passed  [03/90]
> 14) Test second replies http request........................passed  [01/90]
> 15) Test sendfile usage.....................................passed  [02/90]
> 16) Test small static file wget.............................passed  [02/90]
> 17) Test small static file wget cmp.........................passed  [05/90]
> 18) Test large static file wget.............................passed  [02/90]
> 19) Test large static file wget cmp.........................passed  [05/90]
> 20) Test bad static file 404................................passed  [02/90]
> 21) Test bad path 404.......................................passed  [02/90]
> 22) Test get one static file then another...................passed  [03/90]
> 23) Test get two simultaneous static files..................passed  [04/90]
> 24) Test get multiple simultaneous static files.............passed  [05/90]
> 25) Test io submit uses.....................................passed  [02/90]
> 26) Test small dynamic file wget............................passed  [02/90]
> 27) Test small dynamic file wget cmp........................passed  [05/90]
> 28) Test large dynamic file wget............................passed  [02/90]
> 29) Test large dynamic file wget cmp........................passed  [05/90]
> 30) Test bad dynamic file 404...............................passed  [02/90]
> 31) Test get one dynamic file then another..................passed  [04/90]
> 32) Test get two simultaneous dynamic files.................passed  [05/90]
> 34) Test get two simultaneous static and dynamic files......failed  [ 0/90]
> 35) Test get multiple simultaneous static and dynamic files.passed  [05/90]
>
> *Multumesc,*
>
> *Relu Dragan*
>
>
> 2017-05-22 21:03 GMT+03:00 Adrian Stanciu <adrian.stanciu.pub at gmail.com>:
>
>> 2017-05-22 18:59 GMT+03:00 Relu Dragan via so <so at cursuri.cs.pub.ro>:
>> > Salut,
>>
>> Salut,
>>
>> > Local daca testez imi trec toate testele insa pe vm checker imi pica
>> testele
>> > 33 si 34.
>> > Am incercat sa testez si pe masina virtuala de linux de aici [1] si imi
>> trec
>> > toate testele si pe aceasta.
>> > Pentru fiecare conexiune aloc aproximativ 200K dinamic si in teste sunt
>> > maxim 50 de requesturi simultane deci nu cred ca memoria ar fi o
>> problema.
>> > Observ ca pe outputul de pe vm checker testul 33 nu imi apare deloc. E
>> > posibil sa fie un timeout? Testul 33 imi dureaza 30-40 de secunde pe
>> masina
>> > de linux, iar testul 34 1-2 secunde.
>>
>> 30 de secunde la un test este destul de mult (nu ar trebui să dureze
>> mai mult de câteva secunde). Cât durează întreaga execuție în mașina
>> ta virtuală?
>>
>> > Am atasat codul aici [2].
>> > Chiar nu imi dau seama de unde ar putea fi probleme daca masina
>> virtuala are
>> > aceleasi configuratii ca vmchecker.
>>
>> vmchecker-ul are configurat un timeout de 120 de secunde.
>>
>> >
>> > [1] https://ocw.cs.pub.ro/courses/so/info/mv
>> > [2]
>> >
>> https://gitlab.cs.pub.ro/relu.dragan/l3-so-assignments/tree/master/5-aws/lin
>> >
>>
>> Adrian
>>
>
> _______________________________________________
> http://ocw.cs.pub.ro/courses/so/info/lista-discutii
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://cursuri.cs.pub.ro/pipermail/so/attachments/20170522/f8d044b5/attachment.html>